Skip to content

handle model deploy when no metrics to compare #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2024
Merged

handle model deploy when no metrics to compare #1289

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0574574
handle model deploy when no metrics to compare
ChuckHend Jan 17, 2024
667f68e
better warn msg
ChuckHend Jan 17, 2024
d0ff725
fix first run case
ChuckHend Jan 17, 2024
5831025
handle case where exists has no metrics
ChuckHend Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix first run case
  • Loading branch information
@ChuckHend
ChuckHend committed Jan 17, 2024
commit d0ff7251d381ac575a7376ded27022431d21cf17
7 changes: 2 additions & 5 deletions pgml-extension/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ fn train_joint(
let mut deploy = true;

match automatic_deploy {
// Deploy only if metrics are better than previous model.
// Deploy only if metrics are better than previous model, or if its the first model
Some(true) | None => {
if let Ok(Some(deployed_metrics)) = deployed_metrics {
if let Some(deployed_metrics_obj) = deployed_metrics.0.as_object() {
Expand Down Expand Up @@ -297,12 +297,9 @@ fn train_joint(
deploy = false;
}
} else {
warning!("Failed to parse deployed model metrics. Ensure train/test split results in both positive and negative label records.");
warning!("Failed to parse deployed model metrics. Check data types of model metadata on pgml.models.metrics");
deploy = false;
}
} else {
warning!("Failed to obtain currently deployed model metrics. Check if the deployed model metrics are available and correctly formatted.");
deploy = false;
}
}
Some(false) => {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy