Skip to content

Add minified ESM build output #7973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Add minified ESM build output #7973

merged 1 commit into from
Jul 18, 2025
+21 −1

Conversation

nickswalker
Copy link

@nickswalker nickswalker commented Jul 17, 2025 •
edited
Loading

Resolves #7974

Changes:

  • Add p5.esm.min.js output to rollup config with terser minification
  • Include p5.esm.min.js in package.json files field for npm publishing

Screenshots of the change:
N/A

PR Checklist

This PR has no source changes, and only affects developers

@nickswalker
Add minified ESM build output
6c56f2f 
- Add p5.esm.min.js output to rollup config with terser minification
- Include p5.esm.min.js in package.json files field for npm publishing
- Follows existing pattern of hidden sourcemaps for minified builds
@welcome Welcome
Copy link

welcome bot commented Jul 17, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@nickswalker
Copy link
Author

Paging @limzykenneth as you're the main author of the rollup config

@ksen0
Copy link
Member

ksen0 commented Jul 18, 2025

Also pinging the other DevOps stewards in case you have input here: @Vaivaswat2244, @error-four-o-four, @lirenjie95

lirenjie95
lirenjie95 reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@lirenjie95 lirenjie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please also add the change to the documentation? Thanks!

@ksen0
Copy link
Member

ksen0 commented Jul 18, 2025

I'll merge this but re: documentation cc @perminder-17 - WDYT about adding ESM build info to the https://github.com/processing/p5.js/blob/dev-2.0/contributor_docs/release_process.md ? This is a little beyond this issue, but updating this (and/or any other contributor docs) would be good

@ksen0 ksen0 merged commit 6d4540c into processing:dev-2.0 Jul 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenjie95 lirenjie95 lirenjie95 left review comments

@limzykenneth limzykenneth limzykenneth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickswalker @ksen0 @limzykenneth @lirenjie95
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy