Skip to content

ADD : Dialouge after Install/Update/Remove contributions #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ADD : Dialouge after Install/Update/Remove contributions #5818

wants to merge 1 commit into from

Conversation

DeerajTheepshi
Copy link

@DeerajTheepshi DeerajTheepshi commented Mar 15, 2019 •
edited
Loading

@SyamSundarKirubakaran
Copy link

installation of Contribution

Can you make this more clear.!? Also, specify the issue that this PR closes.

@DeerajTheepshi
Copy link
Author

installation of Contribution

Can you make this more clear.!? Also, specify the issue that this PR closes.

By Contribution , I meant, mode/library/tools/Examples installation

@kfrajer
Copy link

kfrajer commented May 12, 2019

Hi Deeraj, I checked the PR and it requires more testing. The changes seems to work for the update action for the trivial case. However, it does not trigger for remove and it does trigger for install but only after downloading step and not after completing the installation of the library. I only tested this when installing/updating/removing libraries. I have not tested this for tools, examples or mode installs.

One suggestion is to place your change at the end of the following function in the same file: private void finishInstall(boolean error). You can test it in the different scenarios and provide details on your tests. This information will make easier to evaluate the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeerajTheepshi @SyamSundarKirubakaran @kfrajer
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy