Skip to content

Add helpful information for why module cannot be uninstalled #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add helpful information for why module cannot be uninstalled #307

wants to merge 1 commit into from

Conversation

artfulrobot
Copy link

When trying to uninstall a module you get a message if you can't because other modules depend on it, or because a field uses it. But you're not told which one. As this info is not listed anywhere else, it's quite hard to find out why.

This PR simply adds to the explanation text:

  • the list of modules for which the module-to-be-uninstalled is a dependency.
  • the list of the (first) field that uses the module.

teppokoivula
teppokoivula reviewed Nov 10, 2024
View reviewed changes
@artfulrobot artfulrobot force-pushed the module-uninstall-deps-info branch 2 times, most recently from ffdf9f2 to 9a45104 Compare November 12, 2024 10:11
poljpocket
poljpocket suggested changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@poljpocket poljpocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your sprintf changes don't really work correctly right now.

@poljpocket
Copy link
Contributor

Also, you should always request a PR against the dev branch of the repo. You can find more 'rules' like this here: https://github.com/processwire/processwire/blob/master/CONTRIBUTING.md

@artfulrobot artfulrobot force-pushed the module-uninstall-deps-info branch from 9a45104 to dff07b9 Compare July 1, 2025 09:08
@artfulrobot artfulrobot changed the base branch from master to dev July 1, 2025 09:08
@artfulrobot artfulrobot force-pushed the module-uninstall-deps-info branch from dff07b9 to feaf2c4 Compare July 1, 2025 09:12
@artfulrobot artfulrobot marked this pull request as draft July 1, 2025 09:12
@artfulrobot artfulrobot force-pushed the module-uninstall-deps-info branch 2 times, most recently from 5883251 to 210f9c3 Compare July 1, 2025 09:16
@artfulrobot artfulrobot marked this pull request as ready for review July 1, 2025 09:17
@artfulrobot
Copy link
Author

@poljpocket Took an embarrassing number of tries to get the formatting correct, but I think I got there in the end! 😆

  • rebased on dev.
  • translate the sprintf format string, not the formatted string.

poljpocket

This comment was marked as outdated.

Sign in to view

poljpocket
poljpocket reviewed Jul 1, 2025
View reviewed changes
@artfulrobot artfulrobot force-pushed the module-uninstall-deps-info branch from 210f9c3 to 21e8e32 Compare July 1, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljpocket poljpocket poljpocket approved these changes

@teppokoivula teppokoivula teppokoivula left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artfulrobot @poljpocket @teppokoivula
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy