Skip to content

Fixing check_zero_fill_value #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2025
Merged

Fixing check_zero_fill_value #886

merged 3 commits into from
Jul 19, 2025

Conversation

prady0t
Copy link
Collaborator

@prady0t prady0t commented Jul 19, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • 🪄 Feature
  • 🐞 Bug Fix
  • 🔧 Optimization
  • 📚 Documentation
  • 🧪 Test
  • 🛠️ Other

Related issues

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

Added a skip condition for size-zero arrays.

@prady0t
Fixing check_zero_fill_value
22e80ed 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #886 will degrade performances by 10.62%

Comparing prady0t:fix-check-zero-fill-value (13ed355) with main (a5d11a2)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_index_fancy[side=100-rank=1-format='coo'] 1,300.9 µs 941.7 µs +38.14%
❌ test_index_slice[side=100-rank=2-format='gcxs'] 1.8 ms 2 ms -10.62%

@hameerabbasi
Copy link
Collaborator

Thanks for the fix, @prady0t! A test would help here.

@prady0t
Adding test for check_zero_fill_value
a781041 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Copy link
Collaborator Author

prady0t commented Jul 19, 2025

Thanks for the review. I've added the tests.

hameerabbasi
hameerabbasi requested changes Jul 19, 2025
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reproducer in the original issue can serve as a test, with a comment that it's a regression test for gh-*.

@prady0t
Copy link
Collaborator Author

prady0t commented Jul 19, 2025

I think the reproducer in the original issue can serve as a test, with a comment that it's a regression test for gh-*.

Makes sense.

@prady0t
Adding test from issue
13ed355 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@hameerabbasi hameerabbasi merged commit 2c3cf00 into pydata:main Jul 19, 2025
16 of 19 checks passed
@hameerabbasi
Copy link
Collaborator

Thanks @prady0t!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: mean -> matmul of size zero array fails
2 participants
@prady0t @hameerabbasi
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy