-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Refactoring/fixing zarr-pyhton v3 incompatibilities in xarray datatrees #10020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
0a2a49e
fixing compatibility with relative paths in open_store function withi…
aladinor ae80662
fixing/refactoring test to be compatible with Zarr-python v3
aladinor 379db18
adding @requires_zarr_v3 decorator to TestZarrDatatreeIO
aladinor 846dc50
replacing 0 with 1 in _create_test_datatree wich will write a chunk
aladinor ddfd0b5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3f9a8fb
fixing issues with groups
aladinor f140658
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0e790eb
Merge branch 'main' into dtree-zarrv3
aladinor 403afa9
fixing issue with dict creation
aladinor 58e8f8e
Merge branch 'dtree-zarrv3' of https://github.com/aladinor/xarray int…
aladinor fd357fa
fixing issues with Mypy
aladinor 8b993a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d4aeeca
refactoring open_store in ZarrStore class to use Zarr.core.group.Grou…
aladinor 3125647
refactoring datree test for zarr ensuring compatibility with zarr-pyt…
aladinor 0c7485b
importing zarr.core.group only inside open_store function
aladinor fdeee94
documenting changes in what's-nwe.rst file
aladinor f3e2c66
Update xarray/backends/zarr.py
aladinor f9f1043
keeping grroup creation compatible with zarr v2
aladinor c118841
Merge branch 'main' into dtree-zarrv3
aladinor ec2086a
fixing issue with mypy
aladinor abaea4e
Merge branch 'main' into dtree-zarrv3
aladinor aa85bed
Merge branch 'main' into dtree-zarrv3
aladinor fce2957
adding root_path equal to '/' when opening group in zarr v3 to avoid …
aladinor e27b4b9
fixing tests accordingly
aladinor d03b003
Merge branch 'dtree-zarrv3' of https://github.com/aladinor/xarray int…
aladinor 810a623
removing print statement
aladinor eabcc76
Merge branch 'main' into dtree-zarrv3
aladinor 60e19d9
Merge branch 'main' into dtree-zarrv3
aladinor 0934461
reverting changes made in unaligned test in zarr
aladinor 6a74275
Merge branch 'main' into dtree-zarrv3
aladinor 011f29c
adding requires_zarr_v3 decorator
aladinor e31c646
changing max_depth=None in Group.members to get all nested groups
aladinor e65f229
fixing unaligned test in datrees using zarr
aladinor 9c88b26
Merge branch 'main' into dtree-zarrv3
dcherian 5a668a4
Merge branch 'main' into dtree-zarrv3
aladinor 53a9309
Merge branch 'main' into dtree-zarrv3
aladinor 72c1ad6
Merge branch 'main' into dtree-zarrv3
aladinor 502981c
Update xarray/backends/zarr.py
aladinor 2f94763
Merge branch 'main' into dtree-zarrv3
aladinor 3e09b61
Merge branch 'main' into dtree-zarrv3
aladinor d5a061e
updating whats-new.rst entry
aladinor a417371
remove funny-looking line and refactor to ensure reading consolidated…
TomNicholas 8756919
parametrize over whether or not we write consolidated metadata
TomNicholas b85d70d
fix consolidated metadata
TomNicholas f1cc331
ian hcanges
ianhi 296ed03
open_datatree_specific_group consolidated true works
ianhi 46c61ca
refactoring
aladinor 77e68e3
Merge branch 'main' into dtree-zarrv3
aladinor 4da72ae
test: add consolidated parametrize to zarr datatree test
ianhi 5f7c6b9
fix: group finding behavior consolidated
ianhi 5dc7df7
Merge remote-tracking branch 'ianhi/aladinor/ian/updates' into dtree_…
TomNicholas 9823d64
remove more debugging print statements
TomNicholas 980ebb4
Merge branch 'dtree-zarrv3' into dtree-zarrv3-2
TomNicholas 30f5bba
revert changes to test fixture
TomNicholas 4d1fdb5
formatting
TomNicholas ecef578
add decorator to parametrize over zarr formats
TomNicholas c2a1f5f
ensure both versions of zarr-python and both versions of zarr-python …
TomNicholas cde6b65
change datatree fixture to not produce values that would be fill_valu…
TomNicholas 09fad6e
refactor test to make expected behaviour clearer
TomNicholas 77575b5
fix wrongly expected behaviour - should not expect inherited variable…
TomNicholas 0a9f874
make arrays no longer scalars to dodge https://github.com/pydata/xarr…
TomNicholas 565938b
Merge branch 'dtree-zarrv3-2' of https://github.com/TomNicholas/xarra…
TomNicholas daf0f42
fix bad merge
TomNicholas 84bde40
parametrize almost every test over zarr_format
TomNicholas 04d937c
parametrize encoding test over zarr_formats
TomNicholas 765c5f0
use xfail in encoding test
TomNicholas 7eee31c
updated expected behaviour of zarr on-disk in light of https://github…
TomNicholas 0969422
fully revert change to simple_datatree test fixture by considered zar…
TomNicholas cacf419
parametrize unaligned_zarr test fixture over zarr_format
TomNicholas 1a60ebe
move parametrize_over_zarr_format decorator to apply to entire test c…
TomNicholas d98abe3
for now explicitly consolidate metadata in test fixture
TomNicholas 2dcefe4
correct bug in writing of consolidated metadata
TomNicholas a88e503
delete commented-out lines
TomNicholas 22ac9b4
merges from main
TomNicholas 69dc976
Revert "merges from main"
TomNicholas 6e3e2aa
fix encodings test for zarr_format=3
TomNicholas 6ce9578
tidy up
TomNicholas 94f0ddc
Merge pull request #1 from TomNicholas/dtree-zarrv3-2
TomNicholas 8573740
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e2a58e8
Merge branch 'main' into dtree-zarrv3
TomNicholas 71288c6
account for different default value of write_empty_chunks between zar…
TomNicholas 47f3315
fix expected encoding key for compressor in zarr-python v2
TomNicholas 2b50a97
account for exception type changing
TomNicholas 59a978d
various typing fixes
TomNicholas fc368ce
Merge branch 'dtree-zarrv3' into dtree-zarrv3-2
TomNicholas cd6aad6
Merge pull request #2 from TomNicholas/dtree-zarrv3-2
TomNicholas 3fb0b7f
remove outdated comment
TomNicholas e06fa25
bool type
TomNicholas 0829c68
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ee4273d
Merge branch 'main' into dtree-zarrv3
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
- Loading branch information
commit 8b993a10cf509d262f0f494972d62d9dd0286088
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.