Skip to content

Improve handling of dtype and NaT when encoding/decoding masked and packaged datetimes and timedeltas #10050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 7, 2025
Merged

Improve handling of dtype and NaT when encoding/decoding masked and packaged datetimes and timedeltas #10050

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
89aa2e2
mask/scale datetimes/timedeltas only if they will be decoded, better …
kmuehlbauer Feb 13, 2025
6180f5a
Merge branch 'main' into timedelta-coding
kmuehlbauer Feb 14, 2025
d4fe3fe
comments
kmuehlbauer Feb 14, 2025
058217e
typing
kmuehlbauer Feb 14, 2025
18274ad
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 14, 2025
b80a578
Apply suggestions from code review
kmuehlbauer Feb 14, 2025
ff189a9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 14, 2025
b7d61bc
fix typing and imports
kmuehlbauer Feb 14, 2025
befa79e
Merge branch 'main' into timedelta-coding
kmuehlbauer Feb 25, 2025
031aaa2
refactor according to review concerns and suggestions
kmuehlbauer Feb 25, 2025
03aa1b8
retain retain dtype for packed data in datetime/timedelta encoding
kmuehlbauer Feb 25, 2025
31ed6bb
simplify code, add whats-new.rst entry
kmuehlbauer Feb 25, 2025
7d5f3cd
Merge branch 'main' into timedelta-coding
kmuehlbauer Mar 5, 2025
dab3b0e
Update xarray/coding/variables.py
kmuehlbauer Mar 5, 2025
a304375
refactor common code into common.py to prevent circular imports when …
kmuehlbauer Mar 5, 2025
2213029
Merge branch 'main' into timedelta-coding
dcherian Mar 7, 2025
818c3a4
Merge branch 'main' into timedelta-coding
kmuehlbauer Mar 7, 2025
200eae2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update xarray/coding/variables.py 
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
  • Loading branch information
@kmuehlbauer @spencerkclark
kmuehlbauer and spencerkclark authored Mar 5, 2025
commit dab3b0e68c43054c533bb52c4353fd8f45e39277
2 changes: 1 addition & 1 deletion xarray/coding/variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@

def _is_time_like(units):
# test for time-like
# return "datetime" for datetetime-like
# return "datetime" for datetime-like
# return "timedelta" for timedelta-like
if units is None:
return False
Expand Down Expand Up @@ -347,7 +347,7 @@
# otherwise numpy unsigned ints will silently cast to the signed counterpart
fill_value = fill_value.item()
# passes if provided fill value fits in encoded on-disk type
new_fill = encoded_dtype.type(fill_value)

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).

Check warning on line 350 in xarray/coding/variables.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.10 min-all-deps 

NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays.  The conversion of 255 to int8 will fail in the future.
For the old behavior, usually:
    np.array(value).astype(dtype)`
will give the desired result (the cast overflows).
except OverflowError:
encoded_kind_str = "signed" if encoded_dtype.kind == "i" else "unsigned"
warnings.warn(
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy