Skip to content

explicitly cast the dtype of where's condition parameter to bool #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 13, 2025
Merged

explicitly cast the dtype of where's condition parameter to bool #10087

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
57155ab
explicitly cast the dtype of `condition` to `bool`
keewis Mar 2, 2025
84a2c84
cast `condition` to bool in every case for `where`
keewis Mar 4, 2025
d4ad871
don't pass a `DataArray` to `where`
keewis Mar 4, 2025
56b254d
use strings to specify the dtype for backwards compat
keewis Mar 4, 2025
ea3d4f7
revert the strings and instead ignore the warning
keewis Mar 4, 2025
8fbfa06
typo
keewis Mar 4, 2025
00b9720
restrict to just numpy
keewis Mar 4, 2025
58ecc32
unrestrict
keewis Mar 4, 2025
afce80b
fall back to `xp.bool_` if `xp.bool` doesn't exist
keewis Mar 12, 2025
4cf9d55
Merge branch 'main' into where-dtype
keewis Mar 12, 2025
8a3e0d2
unskip the `where` test
keewis Mar 12, 2025
3e48223
reverse to avoid warnings
keewis Mar 12, 2025
420d1c0
remove the outdated ignore
keewis Mar 12, 2025
ee17283
Merge branch 'main' into where-dtype
dcherian Mar 13, 2025
7006612
Merge branch 'main' into where-dtype
keewis Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restrict to just numpy
  • Loading branch information
@keewis
keewis committed Mar 4, 2025
commit 00b9720eda7b351f4e596dc4d4e0e87a27ddae3d
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ filterwarnings = [
"default:Duplicate dimension names present:UserWarning:xarray.namedarray.core",
# TODO: numpy.bool was deprecated in older versions of numpy, but is in the Array API
# TODO: remove once we can drop numpy<2
"ignore:In the future `np.bool` will be defined as the corresponding NumPy scalar:FutureWarning",
"ignore:In the future `np.bool` will be defined as the corresponding NumPy scalar:FutureWarning:numpy.*",
# TODO: this is raised for vlen-utf8, consolidated metadata, U1 dtype
"ignore:is currently not part .* the Zarr version 3 specification.",
# TODO: remove once we know how to deal with a changed signature in protocols
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy