Skip to content

Do not rely on np.broadcast_to to perform trivial dimension insertion #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025
Merged

Do not rely on np.broadcast_to to perform trivial dimension insertion #10277

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fe1bc4
Add a test to showcase the differences in the set_dims behavior
hmaarrfk Apr 30, 2025
fb67fc2
Expand on the implementation of set_dims to make the trivial case easier
hmaarrfk Apr 30, 2025
db27ee0
Add release note for https://github.com/pydata/xarray/pull/10277
hmaarrfk Apr 30, 2025
a4ee4e5
Update test_variable.py
hmaarrfk May 1, 2025
f9c2cc3
Merge branch 'main' into broadcast_to
hmaarrfk May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add release note for #10277
  • Loading branch information
@hmaarrfk
hmaarrfk committed Apr 30, 2025
commit db27ee019e386121529b273ab8d8c81b2d4be1b9
5 changes: 5 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ Internal Changes
~~~~~~~~~~~~~~~~
- Avoid stacking when grouping by a chunked array. This can be a large performance improvement.
By `Deepak Cherian <https://github.com/dcherian>`_.
- The implementation of ``Variable.set_dims`` has changed to use array indexing syntax
instead of ``np.broadcast_to`` to perform dimension expansions where
all new dimensions have a size of 1. This should improve compatibility with
duck arrays that do not support broadcasting (:issue:`9462`, :pull:`10277`).
By `Mark Harfouche <https://github.com/hmaarrfk>`_.

.. _whats-new.2025.03.1:

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy