test ds * dt commutativity

pydata · TomNicholas · Oct 15, 2024 · Oct 13, 2024 · Oct 13, 2024 · Oct 13, 2024
commit 909ae0e949286bd659769ef8b493898f9fdfca03
diff --git a/xarray/tests/test_datatree.py b/xarray/tests/test_datatree.py
@@ -1834,7 +1834,29 @@ def test_arithmetic_inherited_coords(self):
         expected["/foo/bar"].data = np.array([8, 10, 12])
         assert_identical(actual, expected)
 
-    # TODO test dataset * datatree commutativity
+    def test_binary_op_commutativity_with_dataset(self):
+        # regression test for #9365
+
+        ds1 = xr.Dataset({"a": [5], "b": [3]})
+        ds2 = xr.Dataset({"x": [0.1, 0.2], "y": [10, 20]})
+        dt = DataTree.from_dict(
+            {
+                "/": ds1,
+                "/subnode": ds2,
+            }
+        )
+
+        other_ds = xr.Dataset({"z": ("z", [0.1, 0.2])})
+
+        expected = DataTree.from_dict(
+            {
+                "/": ds1 * other_ds,
+                "/subnode": ds2 * other_ds,
+            }
+        )
+
+        result = other_ds * dt
+        assert_equal(result, expected)
 
     # TODO test single-node datatree doesn't broadcast