-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
friendlier error messages for missing chunk managers #9676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+54
−14
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
1f71dac
raise an error message while guessing if there's no chunkmanager avai…
keewis 66ed78c
don't skip the no chunkmanager test if dask is not installed
keewis 1dba7b0
Merge branch 'main' into no-chunkmanager
keewis 04d605c
whats-new
keewis b1d4017
ensure at least one chunk manager is available
keewis ab335a9
Merge branch 'main' into no-chunkmanager
keewis 4119473
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f9d1fcc
remove additional blank line from a bad merge
keewis e3cd03e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c646c29
improve the wording
keewis 7bb3433
switch to ImportError
dcherian 5f27715
Merge branch 'main' into no-chunkmanager
TomNicholas 8d6657e
Merge branch 'main' into no-chunkmanager
TomNicholas 34309f6
raise a helpful `ImportError` for known chunk managers
keewis f923622
make sure the new `ImportError` is actually raised
keewis 60adcde
check that the more specific error message is preferred
keewis a69e794
prefer the more specific error
keewis 7dd86c8
Merge branch 'main' into no-chunkmanager
keewis eabd209
also use `ImportError` as indicator for `chunks=None`
keewis 060e77a
Merge branch 'main' into no-chunkmanager
keewis 6c72381
move and improve the whats-new entry
keewis 32892a2
Merge branch 'main' into no-chunkmanager
TomNicholas f778584
captialize global variable KNOWN_CHUNKMANAGERS
TomNicholas 160bbc0
chunkmanagers -> available_chunkmanagers
TomNicholas 55091c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ffd2a59
also use the string repr for printing `manager`
keewis f557f89
reword
keewis b886841
more repr
keewis 50e9c9a
reflow
keewis 7dc7fa0
Merge branch 'main' into no-chunkmanager
keewis 58ff53c
adapt the test to the new error message
keewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'main' into no-chunkmanager
- Loading branch information
commit ab335a99594a9526dc0540a70e079c4da474f011
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.