Skip to content

friendlier error messages for missing chunk managers #9676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Dec 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1f71dac
raise an error message while guessing if there's no chunkmanager avai…
keewis Aug 7, 2024
66ed78c
don't skip the no chunkmanager test if dask is not installed
keewis Oct 24, 2024
1dba7b0
Merge branch 'main' into no-chunkmanager
keewis Oct 24, 2024
04d605c
whats-new
keewis Oct 24, 2024
b1d4017
ensure at least one chunk manager is available
keewis Oct 24, 2024
ab335a9
Merge branch 'main' into no-chunkmanager
keewis Nov 7, 2024
4119473
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 7, 2024
f9d1fcc
remove additional blank line from a bad merge
keewis Nov 7, 2024
e3cd03e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 7, 2024
c646c29
improve the wording
keewis Nov 8, 2024
7bb3433
switch to ImportError
dcherian Nov 18, 2024
5f27715
Merge branch 'main' into no-chunkmanager
TomNicholas Nov 18, 2024
8d6657e
Merge branch 'main' into no-chunkmanager
TomNicholas Nov 22, 2024
34309f6
raise a helpful `ImportError` for known chunk managers
keewis Nov 22, 2024
f923622
make sure the new `ImportError` is actually raised
keewis Nov 22, 2024
60adcde
check that the more specific error message is preferred
keewis Nov 22, 2024
a69e794
prefer the more specific error
keewis Nov 22, 2024
7dd86c8
Merge branch 'main' into no-chunkmanager
keewis Nov 22, 2024
eabd209
also use `ImportError` as indicator for `chunks=None`
keewis Nov 22, 2024
060e77a
Merge branch 'main' into no-chunkmanager
keewis Nov 25, 2024
6c72381
move and improve the whats-new entry
keewis Nov 25, 2024
32892a2
Merge branch 'main' into no-chunkmanager
TomNicholas Nov 29, 2024
f778584
captialize global variable KNOWN_CHUNKMANAGERS
TomNicholas Nov 29, 2024
160bbc0
chunkmanagers -> available_chunkmanagers
TomNicholas Nov 29, 2024
55091c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 29, 2024
ffd2a59
also use the string repr for printing `manager`
keewis Dec 28, 2024
f557f89
reword
keewis Dec 28, 2024
b886841
more repr
keewis Dec 28, 2024
50e9c9a
reflow
keewis Dec 28, 2024
7dc7fa0
Merge branch 'main' into no-chunkmanager
keewis Dec 28, 2024
58ff53c
adapt the test to the new error message
keewis Dec 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into no-chunkmanager
  • Loading branch information
keewis authored Nov 7, 2024
commit ab335a99594a9526dc0540a70e079c4da474f011
7 changes: 5 additions & 2 deletions doc/whats-new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ Bug fixes
By `Stephan Hoyer <https://github.com/shoyer>`_.
- Fix regression in the interoperability of :py:meth:`DataArray.polyfit` and :py:meth:`xr.polyval` for date-time coordinates. (:pull:`9691`).
By `Pascal Bourgault <https://github.com/aulemahal>`_.
- Improve the error message raised when using chunked-array methods if no chunk manager is available (:pull:`9676`)
By `Justus Magin <https://github.com/keewis>`_.

Documentation
~~~~~~~~~~~~~
Expand Down Expand Up @@ -130,8 +132,9 @@ Bug fixes
<https://github.com/josephnowak>`_.
- Fix binning by multiple variables where some bins have no observations. (:issue:`9630`).
By `Deepak Cherian <https://github.com/dcherian>`_.
- Improve the error message raised when using chunked-array methods if no chunk manager is available (:pull:`9676`)
By `Justus Magin <https://github.com/keewis>`_.
- Fix issue where polyfit wouldn't handle non-dimension coordinates. (:issue:`4375`, :pull:`9369`)
By `Karl Krauth <https://github.com/Karl-Krauth>`_.


Documentation
~~~~~~~~~~~~~
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy