Skip to content

time coding refactor #9906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 2, 2025
Merged

time coding refactor #9906

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
da78bcc
refactor out _maybe_strip_tz_from_timestamp for better readability
kmuehlbauer Dec 18, 2024
b55b903
backwards compatible refactor of time coding, preparing for relaxing …
kmuehlbauer Dec 18, 2024
34ad89e
add whats-new.rst entry
kmuehlbauer Dec 18, 2024
69645eb
Update doc/whats-new.rst
kmuehlbauer Dec 18, 2024
313bf2e
Update xarray/coding/times.py
kmuehlbauer Dec 18, 2024
61b2832
Merge branch 'main' into time-decoding-refactor
kmuehlbauer Dec 18, 2024
669539d
only check for unsigned int
kmuehlbauer Dec 29, 2024
678e6d9
return pd.NaT in case of np.iinfo("int64").min
kmuehlbauer Dec 29, 2024
fb5a4fb
skip check for `"iuf"`, it's unneeded
kmuehlbauer Dec 29, 2024
70f96d0
return pd.Timestamp("NaT") instead pd.NaT (fixes typing)
kmuehlbauer Dec 29, 2024
6200aaf
Merge branch 'main' into time-decoding-refactor
kmuehlbauer Dec 29, 2024
de6f3db
Update xarray/coding/times.py
kmuehlbauer Dec 29, 2024
0394a93
Merge branch 'main' into time-decoding-refactor
kmuehlbauer Dec 30, 2024
2fdaf40
Merge branch 'main' into time-decoding-refactor
kmuehlbauer Jan 1, 2025
90de1ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 1, 2025
2178413
fix indentation
kmuehlbauer Jan 1, 2025
f4e10de
add suggestion from code review
kmuehlbauer Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip check for "iuf", it's unneeded
  • Loading branch information
@kmuehlbauer
kmuehlbauer committed Dec 29, 2024
commit fb5a4fb05469b2b23b36ec58cae62071f3b6d60c
2 changes: 1 addition & 1 deletion xarray/coding/times.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ def _decode_datetime_with_pandas(
# this should be safe, as errors would have been raised above
ns_time_unit = _NS_PER_TIME_DELTA[time_unit]
ns_ref_date_unit = _NS_PER_TIME_DELTA[ref_date.unit]
if flat_num_dates.dtype.kind in "iuf" and (ns_time_unit > ns_ref_date_unit):
if ns_time_unit > ns_ref_date_unit:
flat_num_dates *= np.int64(ns_time_unit / ns_ref_date_unit)
time_unit = ref_date.unit

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy