Skip to content

fix mean for datetime-like using the respective time resolution unit #9977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 29, 2025
Merged

fix mean for datetime-like using the respective time resolution unit #9977

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f1e8be4
fix mean for datetime-like by using the respective dtype time resolut…
kmuehlbauer Jan 23, 2025
a66656b
fix mypy
kmuehlbauer Jan 23, 2025
618760d
add PR to existing entry for non-nanosecond datetimes
kmuehlbauer Jan 23, 2025
9226088
Merge branch 'main' into fix-datetime-mean
kmuehlbauer Jan 24, 2025
5d919a0
Update xarray/core/duck_array_ops.py
kmuehlbauer Jan 25, 2025
dfc9e03
cast to "int64" in calculation of datime-like mean
kmuehlbauer Jan 25, 2025
180aa0a
Apply suggestions from code review
kmuehlbauer Jan 26, 2025
295d816
Apply suggestions from code review
kmuehlbauer Jan 26, 2025
892fc07
Merge branch 'main' into fix-datetime-mean
dcherian Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix mypy
  • Loading branch information
@kmuehlbauer
kmuehlbauer committed Jan 23, 2025
commit a66656bdb88059d63f8e9c49cec28dd9f1b3c089
4 changes: 2 additions & 2 deletions xarray/tests/test_duck_array_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,8 +877,8 @@ def test_datetime_to_numeric_datetime64(dask, time_unit: PDDatetimeUnitOptions):
result = duck_array_ops.datetime_to_numeric(
times, datetime_unit="h", dtype=dtype
)
expected = 24 * np.arange(0, 35, 7).astype(dtype)
np.testing.assert_array_equal(result, expected)
expected2 = 24 * np.arange(0, 35, 7).astype(dtype)
np.testing.assert_array_equal(result, expected2)


@requires_cftime
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy