Skip to content

Fix typo in missing-member-hint-distance documentation #10314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

correctmost
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

The missing-member-hint-distance value is the upper limit rather than the lower limit:

if distance <= distance_threshold:
possible_names.append((name, distance))

@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry labels Mar 25, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.7 milestone Mar 25, 2025
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) March 25, 2025 20:05
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.89%. Comparing base (5b2aa6c) to head (cc65131).
Report is 254 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10314      +/-   ##
==========================================
+ Coverage   95.84%   95.89%   +0.05%     
==========================================
  Files         174      175       +1     
  Lines       18993    19082      +89     
==========================================
+ Hits        18204    18299      +95     
+ Misses        789      783       -6     
Files with missing lines Coverage Ξ”
pylint/checkers/typecheck.py 96.67% <ΓΈ> (+0.10%) ⬆️

... and 5 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas Pierre-Sassoulas merged commit f98805e into pylint-dev:main Mar 25, 2025
50 of 51 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
@correctmost correctmost deleted the cm/update-edit-distance-docs branch March 25, 2025 20:20
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit cc65131

Pierre-Sassoulas pushed a commit that referenced this pull request Mar 25, 2025
(cherry picked from commit f98805e)

Co-authored-by: correctmost <134317971+correctmost@users.noreply.github.com>
@Julfried
Copy link
Contributor

I do not know what happened but something got messed up with this PR, because in the .rst file in main it is still written as minimum:

*The minimum edit distance a name should have in order to be considered a similar match for a missing member name.*

@Pierre-Sassoulas
Copy link
Member

Yeah I noticed that too. The CI fail on main and didn't fail on the branch : very strange. Let's fix it in #10320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy