Skip to content

Update docs to make clear sharp regression discontinuity design #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 1, 2025

Conversation

HPCurtis
Copy link
Contributor

@HPCurtis HPCurtis commented Feb 1, 2025

Update of docs files to achieve the first step of issue [#221]
(#221 (comment)). Further doc changes will be likely once a FuzzyRegressionDiscontinuity class is implemented.


📚 Documentation preview 📚: https://causalpy--437.org.readthedocs.build/en/437/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (9b85b2a) to head (d1688bc).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          31       31           
  Lines        1985     1985           
=======================================
  Hits         1874     1874           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took me so long to get to. Looks good. Thanks!

@drbenvincent
Copy link
Collaborator

drbenvincent commented Feb 27, 2025

Pre commit checks were failing. Just ran them and it updated the copyright year, see previous commit. It updated 2024 to 2025.

@drbenvincent
Copy link
Collaborator

@lucianopaz could I get your input here? We've got 2 issues in the remote checks.

Problem 1

One of them is your https://github.com/lucianopaz/head_of_apache pre commit check. It's already ran this and it changed

- Copyright 2024 The PyMC Labs Developers
+ Copyright 2025 The PyMC Labs Developers

Which seems fine.

But now it seems to want to do

- Copyright 2025 The PyMC Labs Developers
+ Copyright 2025 - 2025 The PyMC Labs Developers

which seems like a bug to me.

Problem 2

The other issue involves the setting up of the remote environment

Screenshot 2025-02-27 at 20 57 00

Copilot is telling me to:

  1. Add a step to build the wheel file before the installation step.
  2. Ensure the dist directory exists and contains the wheel file.

But thought I'd just check this makes sense before I trust it :)

Thanks for any input you can give

@lucianopaz
Copy link
Collaborator

I can answer on the head of apache thing. The people from numfocus said that leaving just the current year on the license header was wrong because it implied that we were forfeiting the license from past years. That's why the format that the hook imposes now is first_year - current_year_or_present. When there's only one year in the license header, it assumes that's the start year for the license and then does first_year - current_year. If you prefer, you can make the license show first_year - present.

If you want, I can change the start years to the year in which CausalPy was first released, and then the license will show 2022-2025

@drbenvincent
Copy link
Collaborator

Ah, that makes sense. Sure thing, happy for you to do that :)

@drbenvincent drbenvincent merged commit c0ea8a5 into pymc-labs:main Mar 1, 2025
8 checks passed
@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy