-
Notifications
You must be signed in to change notification settings - Fork 72
Update docs to make clear sharp regression discontinuity design #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to make clear sharp regression discontinuity design #437
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 31 31
Lines 1985 1985
=======================================
Hits 1874 1874
Misses 111 111 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took me so long to get to. Looks good. Thanks!
Pre commit checks were failing. Just ran them and it updated the copyright year, see previous commit. It updated 2024 to 2025. |
@lucianopaz could I get your input here? We've got 2 issues in the remote checks. Problem 1One of them is your https://github.com/lucianopaz/head_of_apache pre commit check. It's already ran this and it changed
Which seems fine. But now it seems to want to do
which seems like a bug to me. Problem 2The other issue involves the setting up of the remote environment ![]() Copilot is telling me to:
But thought I'd just check this makes sense before I trust it :) Thanks for any input you can give |
I can answer on the head of apache thing. The people from numfocus said that leaving just the current year on the license header was wrong because it implied that we were forfeiting the license from past years. That's why the format that the hook imposes now is If you want, I can change the start years to the year in which CausalPy was first released, and then the license will show |
Ah, that makes sense. Sure thing, happy for you to do that :) |
Update of docs files to achieve the first step of issue [#221]
(#221 (comment)). Further doc changes will be likely once a FuzzyRegressionDiscontinuity class is implemented.
📚 Documentation preview 📚: https://causalpy--437.org.readthedocs.build/en/437/