Use an UTF8 enabled locale for the run() environment. #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Sep 13, 2023
|
thanks 🤟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not managed to make a unit test that recreates the problem. While failing with that, I think I have narrowed down the true origin of the problem:
It is not mercurial having trouble with LC_ALL=C. It is Python itself that fails during start-up, when it encounters a pth-file in site-packages, that has a non-ascii character inside of it. This in turn only happens when I initiate the
pip wheelcommand while my virtualenv (with an editable install of the project) is active.In order to make a test for this, one would need to prep the test by installing an (in)appropriate package in the test environment. I do not want to take on that type of effort, so I'll just leave this one-liner here for you to accept or reject!
With my findning on the core of the problem, I have a solid work-around available (just don't run pip wheel with an active virtualenv), so I don't feel very strongly about the issue any more.
Kind regards,
Arvid