feat: Dagum distribution #2014
Merged
feat: Dagum distribution #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The stuck test case in modeling passes locally on both py3.9 and py3.10. |
|
Thanks @Qazalbash! Sorry for the late response. I think you can revise some parameters in |
|
could you merge with the master branch? the failing tests have been fixed there |
|
Just curious, why did you remove mean/var? is it unstable or something? |
|
Yes, they were unstable! I couldn't figure out why the test cases for them were failing. |
|
Could you add them back? I can take a look. |
|
Ok I am reverting the commit. |
fehiepsi
reviewed
Jun 3, 2025
fehiepsi
reviewed
Jun 3, 2025
…ition" This reverts commit 2119a59.
fehiepsi
reviewed
Jun 3, 2025
fehiepsi
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the implementation of the Dagum distribution, along with the unit tests and documentation.