Fix #735 - Test <script type="py"> against all special cases #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
commented
Apr 27, 2023
| from .support import PyScriptTest, skip_worker | ||
|
|
||
|
|
||
| class TestDisplayLineBreak(PyScriptTest): |
There was a problem hiding this comment.
@FabioRosado dho! ... we probably overlooked at this (initial) class name ... worth amending from main? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than a fix this MR showcases that when special chars are meant and needed, the
<script type="py">solution works out of the box without any encoding/decoding indirection and without DOMParser on its way.Changes
<script type="py">none of the issues presented in Correctly handle HTML entities inside <py-script> source code #735 existChecklist
docs/changelog.md