gh-103629: Update typing.Unpack docs in compliance with PEP 692 #103894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks! Could you add an entry to the 3.12 What's New and to the NEWS as well? |
|
Thought about doing it in a separate PR but I can add it as a part of this one :) let me do that. |
AlexWaygood
approved these changes
Apr 26, 2023
JelleZijlstra
approved these changes
Apr 26, 2023
|
Thanks @franekmagiera! |
rinarakaki
reviewed
Oct 3, 2023
|
|
||
| from typing import TypedDict, Unpack | ||
|
|
||
| class Movie(TypedDict): |
There was a problem hiding this comment.
4 space tab would've been more consistent.
There was a problem hiding this comment.
3 spaces are the convention in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.