gh-125522: Fix bare except in test_math.testTan #125544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
Oct 15, 2024
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev
approved these changes
Oct 19, 2024
|
@serhiy-storchaka, what do you think on keeping only self.assertRaises? |
|
I think that this test implies that NaN is a valid returning value. If we want to change this, open a separate issue. It should be discussed with Mark and Tim. |
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2024
(cherry picked from commit 4b421e8) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2024
(cherry picked from commit 4b421e8) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-125726 is a backport of this pull request to the 3.13 branch. |
|
GH-125727 is a backport of this pull request to the 3.12 branch. |
iritkatriel
added a commit
that referenced
this pull request
Oct 19, 2024
iritkatriel
added a commit
that referenced
this pull request
Oct 19, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple rewrite of the test to avoid bare except and make the test's intention clearer