Skip to content

gh-126662: naming consistency for signal.ItimerError #126712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-126662: naming consistency for signal.ItimerError #126712

wants to merge 2 commits into from

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Nov 12, 2024 •
edited
Loading

This MR updates the __name__ attribute of signal.ItimerError to match its import path. Let me know if a NEWS entry is needed for this; I was on the fence about it.

@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Open
@ZeroIntensity ZeroIntensity added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 22, 2024
ZeroIntensity
ZeroIntensity approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is a slight breaking change, but I don't think anyone was relying on this buggy behavior anyway.

@tomasr8 tomasr8 removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tungol @erlend-aasland @ZeroIntensity @serhiy-storchaka @tomasr8
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy