Improve the highlight class injection

python · encukou · Feb 5, 2025 · Nov 20, 2024 · Dec 4, 2024 · Dec 4, 2024
commit ef3c552a3636dbdc20e4753f55b6c8cae89336c3
@@ -1,13 +1,21 @@
 import re

 from docutils import nodes
 from docutils.parsers.rst import directives
 from sphinx import addnodes
 from sphinx.util.docutils import SphinxDirective
 from sphinx.util.nodes import make_id
 from sphinx.domains.std import token_xrefs
 
 
+class snippet_literal_string(nodes.inline):
+    """Node for a string literal in a grammar snippet."""
+
+    def __init__(self) -> None:
+        # Use the Pygments highlight class for `Literal.String.Other`
+        super().__init__(classes=['sx'])
+
+
 class GrammarSnippetBase(SphinxDirective):
     """Common functionality for GrammarSnippetDirective & CompatProductionList."""
 
@@ -31,8 +39,6 @@
         literal = nodes.literal_block(
             rawsource,
             '',
-            # TODO: Use a dedicated CSS class here and for strings.
-            # and add it to the theme too
             classes=['highlight'],
         )
 
@@ -70,7 +76,7 @@
                     case {'rule_ref': ref_text}:
                         literal += token_xrefs(ref_text, group_name)
                     case {'single_quoted': name} | {'double_quoted': name}:
-                        string_node = nodes.inline(classes=['nb'])
+                        string_node = snippet_literal_string()
                         string_node += nodes.Text(name)
                         literal += string_node
                     case _: