Skip to content

gh-87790: support thousands separators for formatting fractional part of Decimal #132202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2025

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Apr 7, 2025

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka requested a review from hugovk July 3, 2025 13:27
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
@hugovk hugovk changed the title gh-87790: support thousands separators for formatting fractional part of Decimal's gh-87790: support thousands separators for formatting fractional part of Decimal Jul 7, 2025
@hugovk hugovk merged commit 90a5b44 into python:main Jul 7, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 90a5b4402bc6b8f44a9fe9a5299721b1887b50f8 3.14

@skirpichev skirpichev deleted the frac-sep-Decimal/87790 branch July 7, 2025 08:59
@serhiy-storchaka serhiy-storchaka added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
…l part of Decimal (pythonGH-132202)

(cherry picked from commit 90a5b44)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136365 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
…al part of Decimal (GH-132202) (#136365)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy