Skip to content

gh-87790: support thousands separators for formatting fractional part of Fraction #132204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

gh-87790: support thousands separators for formatting fractional part of Fraction #132204

merged 2 commits into from
Jul 7, 2025

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Apr 7, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2025
Open
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test also errors for '.f' and '.6_f'.

@skirpichev
Copy link
Contributor Author

Test also errors for '.f' and '.6_f'.

I suspect you are about ._6f. This test was added in test_invalid_formats(). Missing precision already was tested.

@serhiy-storchaka serhiy-storchaka requested a review from hugovk July 3, 2025 13:02
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@hugovk hugovk changed the title gh-87790: support thousands separators for formatting fractional part of Fraction's gh-87790: support thousands separators for formatting fractional part of Fraction Jul 7, 2025
@hugovk hugovk merged commit 3e849d7 into python:main Jul 7, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14

@skirpichev skirpichev deleted the frac-sep-Fraction/87790 branch July 7, 2025 08:58
@skirpichev skirpichev added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14

@serhiy-storchaka serhiy-storchaka added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@skirpichev @miss-islington
pythongh-87790: support thousands separators for formatting fractiona…
8e54f7a 
…l part of Fraction (pythonGH-132204)

(cherry picked from commit 3e849d7)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136364 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
@miss-islington @skirpichev
[3.14] gh-87790: support thousands separators for formatting fraction…
442b781 
…al part of Fraction (GH-132204) (#136364)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@skirpichev @AndPuQing
pythongh-87790: support thousands separators for formatting fractiona…
d2730af 
…l part of Fraction (python#132204)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev @Pranjal095
pythongh-87790: support thousands separators for formatting fractiona…
8c96584 
…l part of Fraction (python#132204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@picnixz picnixz Awaiting requested review from picnixz

@hugovk hugovk Awaiting requested review from hugovk

Assignees

@hugovk hugovk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skirpichev @serhiy-storchaka @hugovk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy