Skip to content

GH-132508: Use tagged integers on the evaluation stack for the last instruction offset #132545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 29, 2025
Merged

GH-132508: Use tagged integers on the evaluation stack for the last instruction offset #132545

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ba30e9a
Use tagged integers on the evaluation stack for lasti
markshannon Apr 11, 2025
1d223c3
Add support for Py_STACKREF_DEBUG
markshannon Apr 14, 2025
246199b
Add news
markshannon Apr 15, 2025
b1b1252
Fix dump_item
markshannon Apr 15, 2025
8d3c3ea
Clarify division between pre-defined stackref indexes and others
markshannon Apr 15, 2025
aa4ddf0
Cast before shifting
markshannon Apr 15, 2025
e223e36
Integer tagging doesn't escape
markshannon Apr 15, 2025
9e11cc7
Push assert up to caller
markshannon Apr 15, 2025
79ed469
Avoid side effects in macro
markshannon Apr 16, 2025
b491544
Remove debug code
markshannon Apr 16, 2025
f6126b1
Handle negative ints properly in Py_STACKREF_DEBUG build
markshannon Apr 16, 2025
1b4aba6
Brandt's fix to the stencils
markshannon Apr 28, 2025
d84cd2d
Put Brandt's patch in the right place :)
markshannon Apr 29, 2025
fb89cd9
Replace is_tagged_int with PyStackRef_IsTaggedInt
markshannon Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid side effects in macro
  • Loading branch information
@markshannon
markshannon committed Apr 16, 2025
commit 79ed46982ea950b15ebac18526a671f17c7d622b
5 changes: 3 additions & 2 deletions Objects/frameobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1813,15 +1813,16 @@ frame_lineno_set_impl(PyFrameObject *self, PyObject *value)
start_stack = pop_value(start_stack);
}
while (start_stack > best_stack) {
_PyStackRef popped = _PyFrame_StackPop(self->f_frame);
if (top_of_stack(start_stack) == Except) {
/* Pop exception stack as well as the evaluation stack */
PyObject *exc = PyStackRef_AsPyObjectBorrow(_PyFrame_StackPop(self->f_frame));
PyObject *exc = PyStackRef_AsPyObjectBorrow(popped);
assert(PyExceptionInstance_Check(exc) || exc == Py_None);
PyThreadState *tstate = _PyThreadState_GET();
Py_XSETREF(tstate->exc_info->exc_value, exc == Py_None ? NULL : exc);
}
else {
PyStackRef_XCLOSE(_PyFrame_StackPop(self->f_frame));
PyStackRef_XCLOSE(popped);
}
start_stack = pop_value(start_stack);
}
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy