Skip to content

gh-132657: Add free-threading scaling benchmark for copy.copy and copy.deepcopy #132658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-132657: Add free-threading scaling benchmark for copy.copy and copy.deepcopy #132658

wants to merge 2 commits into from

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Apr 17, 2025 •
edited by bedevere-app bot
Loading

In this branch two benchmarks for the free-threading scaling are added. They are not completely microbenchmarks (they test multiple aspects of the free-threaded performance).

@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2025
Open
colesbury
colesbury reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but in general my preference is to add these benchmarks when we fix the scaling issue. I think of these like regression tests, and having a mix of "passing" and "failing" cases makes it harder to notice regressions.

@eendebakpt @colesbury
Apply suggestions from code review
430cb5c 
Co-authored-by: Sam Gross <colesbury@gmail.com>
@eendebakpt
Copy link
Contributor Author

Thanks for the feedback. I suspect we will only need one of the two benchmarks as a regression test (as the reason for not scaling seems to be the same). Once we have a better scaling, I will remove one of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury left review comments

Assignees
No one assigned
Labels
awaiting review topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eendebakpt @colesbury @kumaraditya303
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy