gh-133656: Remove deprecated zipimport.zipimporter.load_module
#133662
Conversation
|
considering how pyhton imports work, You might have to modify the files that run on import or any references to load_module. This will be a really daunting task for you :( sorry! |
|
|
||
| * :mod:`zipimport`: | ||
|
|
||
| * :meth:`~zipimport.zipimporter.load_module` has been deprecated since | ||
| Python 3.10. Use :meth:`~zipimport.zipimporter.exec_module` instead. | ||
| (Contributed by Jiahao Li in :gh:`125746`.) |
There was a problem hiding this comment.
Same issue again @hugovk, do we keep these? This should be in the devguide.
There was a problem hiding this comment.
I saw that others did it this way recently. #133876
I remember that before it was directly removed👀
Okay, I will modify this after a few hours
There was a problem hiding this comment.
First, we shouldn't include the pending-removal-in-X.Y.rst file in X.Y's deprecations/index.rst, there's no point showing it there.
Given that, is it easier to leave the contents as is (fixing warnings where necessary), for when we want to backport changes to older branches?
|
@Wulian233 Will review tmrw |
|
Resolved a new merge conflict @brettcannon Would you like to review it, thanks! |
Ready review!
zipimport.zipimporter.load_module#133656📚 Documentation preview 📚: https://cpython-previews--133662.org.readthedocs.build/