gh-133829: Update zipimport example to not mention Python 2.3 #133835
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
@AA-Turner Please give final review |
|
Someone please merge this since @AA-Turner isnt reviewing any time soon |
|
Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉) |
|
Sorry, bad mood that day :) finals
…On Sun, May 18, 2025 at 10:28 AM Peter Bierma ***@***.***> wrote:
*ZeroIntensity* left a comment (python/cpython#133835)
<#133835 (comment)>
Let's be patient! Adam will review when he gets a chance to do so. People
are busy, and complaining doesn't get it landed any faster (though
sometimes I wish it did 😉)
—
Reply to this email directly, view it on GitHub
<#133835 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNITW5YDDF5JIKSGGUQNGPD27CKJZAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBZGAZDCOJQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
Again, be patient. Spam pinging someone does not help their motivation to review. The devguide recommends waiting at least a month before tagging anyone. |
This comment was marked as resolved.
This comment was marked as resolved.
|
It is been roughly a month since last review. Someone either please give final review or merge. Thank you! |
|
P.S. zerointensity: congrats on becoming a core dev 🎉 |
|
@AA-Turner it has been a month... and considering it has got an approval from a core dev @ZeroIntensity I didn't post it on discourse. I'm not sure what to do here... |
|
We generally try to avoid overriding another core dev's request for changes. @AA-Turner Have your concerns been addressed? I'm comfortable with merging this if you confirm that you don't want to block. |
No response for over a week. I don't think @AA-Turner will reply |
|
Hi Rihaan. Your enthusiasm is commendable, but I would ask that you stop frequently pinging me and other core developers. This PR remains in my queue to look at (& hopefully merge). However, there are nearly 2,000 open PRs in total. If I were to spend just a minute reviewing each, it would take over 30 hours. The devguide recommends a month to give you an indication of the timelines that the project can run on, and to set your expectations -- it is unfair to others if we unduly prioritise your PR solely as you ping us more frequently. These timelines should be used as a guide, rather than as a target. As a reminder, we are volunteers giving up our time for free to contribute to and maintain the project, so sometimes things do take a bit longer. I regret that this PR is still outstanding, but to be transparent, I have been reluctant to engage in this thread given some of the comments. A |
|
Sorry for being a big annoying ... when I'm stressed sometimes I do t think and make comments like that especially around finals time I promise I didn't mean it the way it came across, i won’t again. Thank you though for your time
…On Wed, Jul 9, 2025 at 18:53 Adam Turner ***@***.***> wrote:
*AA-Turner* left a comment (python/cpython#133835)
<#133835 (comment)>
Hi Rihaan. Your enthusiasm is commendable, but I would ask that you stop
frequently pinging me and other core developers. This PR remains in my
queue to look at (& hopefully merge). However, there are nearly 2,000 open
PRs in total. If I were to spend just a minute reviewing each, it would
take over 30 hours. The devguide recommends a month to give you an
indication of the timelines that the project can run on, and to set your
expectations -- it is unfair to others if we unduly prioritise your PR
solely as you ping us more frequently. These timelines should be used as a
guide, rather than as a target.
As a reminder, we are volunteers giving up our time for free to contribute
to and maintain the project, so sometimes things do take a bit longer. I
regret that this PR is still outstanding, but to be transparent, I have
been reluctant to engage in this thread given some of the comments.
A
—
Reply to this email directly, view it on GitHub
<#133835 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNITW5ZOQJLO76WZY3JSXG33HUJWXAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJSGY3DGMJTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
#133829
Updates this zipimport example: https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example
This will close #133829
Ready for review
📚 Documentation preview 📚: https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples