-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-134026: Fix grammar description of for statement #134034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6873af5
doc: clarify for_stmt grammar by replacing starred_list with expressi…
Yash-Vijay29 3795065
star_expressions
Yash-Vijay29 02c6d47
Merge branch 'main' into fix-for-stmt-docs
Yash-Vijay29 1152b1b
star_expressions
Yash-Vijay29 9967ec9
star_expressions
Yash-Vijay29 9442bf8
doc: clarify for_stmt grammar by replacing starred_list with expressi…
Yash-Vijay29 c9abb45
star_expressions
Yash-Vijay29 ec6005b
star_expressions
Yash-Vijay29 e760500
star_expressions
Yash-Vijay29 b8beb7d
star_expressions
Yash-Vijay29 7f53e8b
Merge remote-tracking branch 'origin/fix-for-stmt-docs' into fix-for-…
Yash-Vijay29 e908fce
Update compound_stmts.rst
Yash-Vijay29 50f1e09
Update compound_stmts.rst
Yash-Vijay29 8e860fa
Update compound_stmts.rst
Yash-Vijay29 0866ba2
Update compound_stmts.rst
Yash-Vijay29 27c94a6
Update compound_stmts.rst
Yash-Vijay29 99c40ff
Update compound_stmts.rst
Yash-Vijay29 a448548
Update compound_stmts.rst
Yash-Vijay29 32e1ee1
Merge branch 'python:main' into fix-for-stmt-docs
Yash-Vijay29 cab198f
Update compound_stmts.rst
Yash-Vijay29 5b1fad3
Update compound_stmts.rst
Yash-Vijay29 a4839cb
Update compound_stmts.rst
Yash-Vijay29 9af4d49
Update compound_stmts.rst
Yash-Vijay29 0ef3fb7
Merge branch 'main' into fix-for-stmt-docs
Yash-Vijay29 5ce932e
Update compound_stmts.rst
Yash-Vijay29 0417261
Update compound_stmts.rst
Yash-Vijay29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see warnings on your pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay yea saw it. found a "starred_expression_list" in the https://docs.python.org/3/reference/expressions.html#grammar-token-python-grammar-starred_expression_list. I will try to link it to that instead then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skirpichev done, i reviewed it locally and doc seems proper. starred_list is turned into starred_expression_list mentioned already in https://docs.python.org/3/reference/expressions.html#grammar-token-python-grammar-starred_expression_list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this comma? Seems unrelated to the pr content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While changing i just noticed a small grammar error and thought of fixing it. Its a small mistake but comma should be there after the tuple, I can make a separate PR for it if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StanFromIreland, does this looks correct for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an oxford comma, its usage is varied across contexts, but generally recommended in formal writing.
It is unrelated to this pr and not very important, I am not against it staying, but I wouldn't be heavily opposed to removing it either.