Revert "gh-128639: Don't assume one thread in subinterpreter finalization (gh-128640)" #134256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalization (pythongh-128640)" This reverts commit 9859791.
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 79ed70e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134256%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
Please explain the rationale for the revert in the commit message. |
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
May 24, 2025
…inalization (pythongh-128640)" (pythongh-134256) This reverts commit 27bd082.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…nalization (pythongh-128640)" (pythongh-134256) This reverts commit 9859791. The original change broke the iOS and android buildbots, where the tests are run single-process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9859791.