Skip to content

gh-81148: Eliminate unnecessary check in _strptime when determining AM/PM #13428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-81148: Eliminate unnecessary check in _strptime when determining AM/PM #13428

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ade347d
bpo-36967: Eliminate unnecessary check in _strptime when determining …
GPHemsley May 19, 2019
4dbc38d
Pauls suggestion to refactor test
StanFromIreland Jul 8, 2025
127d100
Merge branch 'main' into strptime-am-pm
StanFromIreland Jul 8, 2025
f6fc0c5
Fix test
StanFromIreland Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test
  • Loading branch information
@StanFromIreland
StanFromIreland authored Jul 8, 2025
commit f6fc0c59a0b5ab897526a186751882a3fc30f360
2 changes: 1 addition & 1 deletion Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2925,7 +2925,7 @@ def test_strptime(self):
with self.assertRaises(ValueError): strptime("z", "%z")

def test_strptime_ampm(self):
dt = datetime(1999, 3, 17, 0, 44, 55, 2, 76, 0)
dt = datetime(1999, 3, 17, 0, 44, 55, 2)
for hour in range(0, 24):
with self.subTest(hour=hour):
new_dt = dt.replace(hour=hour)
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy