Skip to content

gh-51067: Add remove() and repack() to ZipFile #134627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 72 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
6aed859
Add `remove()` and `repack()` to `ZipFile`
danny0838 May 24, 2025
5453dbc
📜🤖 Added by blurb_it.
blurb-it[bot] May 24, 2025
80ab2e2
Fix and optimize test code
danny0838 May 24, 2025
72c2a66
Handle common setups with `setUpClass`
danny0838 May 24, 2025
a4b410b
Add tests for mode `w` and `x` for `remove()`
danny0838 May 24, 2025
a9e85c6
Introduce `_calc_initial_entry_offset` and refactor
danny0838 May 24, 2025
236cd06
Optimize `_calc_initial_entry_offset` by introducing cache
danny0838 May 24, 2025
bdc58c7
Introduce `_validate_local_file_entry` and refactor
danny0838 May 24, 2025
c3c8345
Introduce `_debug` and refactor
danny0838 May 24, 2025
1b7d75a
Introduce `_move_entry_data` and rework chunk_size passing
danny0838 May 25, 2025
51c9254
Refactor `_validate_local_file_entry`
danny0838 May 25, 2025
0d971d8
Add `strict_descriptor` option
danny0838 May 25, 2025
8f0a504
Fix and improve validation tests
danny0838 May 25, 2025
0cb8682
Remove obsolete NameToInfo updating
danny0838 May 25, 2025
a788a00
Use `zinfo` rather than `info`
danny0838 May 25, 2025
ae01b8c
Raise on overlapping file blocks
danny0838 May 25, 2025
edee203
Rework writing protection
danny0838 May 25, 2025
555ac78
Update doc
danny0838 May 25, 2025
95fde31
Fix typo
danny0838 May 26, 2025
8a448e4
Add test for bytes between file entries
danny0838 May 26, 2025
4c35eb2
Check `testzip()` after zip file closed
danny0838 May 26, 2025
926338c
Support `repack(removed)`
danny0838 May 26, 2025
e76f9a1
Fix bytes between entries be removed when `removed` is passed
danny0838 May 26, 2025
93f4c25
Fix bad test code
danny0838 May 26, 2025
9e94209
Revise docstring
danny0838 May 27, 2025
3ef72c6
Add `tearDown` for tests
danny0838 May 28, 2025
fbf7588
Rename methods and parameters
danny0838 May 28, 2025
81a419a
Adjust parameter order
danny0838 May 28, 2025
c62a455
Optimize code and revise comment
danny0838 May 28, 2025
a05353c
Improve debug for `_ZipRepacker.repack()`
danny0838 May 29, 2025
3d0240c
Rework `_validate_local_file_entry_sequence` to return size or None
danny0838 May 29, 2025
31c4c93
Rework `_validate_local_file_entry_sequence` to allow passing no `che…
danny0838 May 29, 2025
f8fade1
Introduce `_scan_data_descriptor_no_sig_by_decompression`
danny0838 May 30, 2025
c80d21b
Strip only entries immediately following a referenced entry
danny0838 May 29, 2025
e1caea9
Adjust method names
danny0838 May 30, 2025
2b23d46
Add memory usage test
danny0838 May 30, 2025
de4f15b
Fix rst
danny0838 May 30, 2025
ea3259f
Optimize code
danny0838 Jun 1, 2025
fef92c4
Fix and optimize `_iter_scan_signature`
danny0838 Jun 1, 2025
8067b0c
Fix `_scan_data_descriptor`
danny0838 Jun 1, 2025
92d3a9c
Fix and optimize `_scan_data_descriptor_no_sig`
danny0838 Jun 1, 2025
b5d7ae3
Rename `_trace_compressed_block_end`
danny0838 Jun 1, 2025
1d5ec61
Fix `_scan_data_descriptor_no_sig_by_decompression`
danny0838 Jun 1, 2025
db9d0d6
Add tests for `_ZipRepacker`
danny0838 Jun 1, 2025
aaa566c
Remove unneeded import
danny0838 Jun 1, 2025
578c7c8
Add requirements
danny0838 Jun 1, 2025
c470c33
Fix `_scan_data_descriptor_no_sig_by_decompression` when library not …
danny0838 Jun 1, 2025
b1dcb07
Test with pre-calculated CRC
danny0838 Jun 1, 2025
04cddef
Remove unneeded import
danny0838 Jun 1, 2025
797a62c
Fix and optimize `repack`
danny0838 Jun 1, 2025
3b2f232
Remove unneeded catch type
danny0838 Jun 14, 2025
cb549c9
Patch more explicitly
danny0838 Jun 14, 2025
0f50a6f
Remove unneeded variables
danny0838 Jun 14, 2025
c759b63
Improve dependency check for decompression tests
danny0838 Jun 14, 2025
1ece5b1
Refactor and optimize `RepackHelperMixin`
danny0838 Jun 14, 2025
ce88616
Update NEWS
danny0838 Jun 20, 2025
5f093e5
Sync with danny0838/zipremove@1691ca25bf971cf1e45d5ed7d22c512636f20cb8
danny0838 Jun 20, 2025
11c0937
Revise NEWS
danny0838 Jun 20, 2025
4b2176e
Sync with danny0838/zipremove@1843d87b70e6cb129fb55446eaf4486a87d2af4d
danny0838 Jun 21, 2025
d9824ce
Fix timezone related timestamp issue
danny0838 Jun 21, 2025
85811ab
Simplify tests with data descriptors
danny0838 Jun 22, 2025
748ac63
Sync with danny0838/zipremove@e79042768f3c2541e0226f6bed3a9ff2ee04fac0
danny0838 Jun 23, 2025
001a8d0
Sync with danny0838/zipremove@87bcdb50411a355d24c35f31dcbe4273c0568cf8
danny0838 Jun 24, 2025
3a364ce
Sync with danny0838/zipremove@6a78bd15de87afde510f8a1b6364365c6e17f252
danny0838 Jun 25, 2025
0832528
Sync with danny0838/zipremove@092f98b4d7b3a0cd335fe4ba64e7090ebb3dc6da
danny0838 Jun 27, 2025
f20ec5d
Revise doc for `repack`
danny0838 Jun 28, 2025
8e69c09
Revise doc for `remove`
danny0838 Jun 28, 2025
725b1a3
Update `data_offset`
danny0838 Jun 29, 2025
9e82bb7
Revise doc for `repack`
danny0838 Jul 1, 2025
93db94a
Revise doc for `repack`
danny0838 Jul 2, 2025
72673e0
Sync with danny0838/zipremove@8bedf7c9b891acadc3393d2f1267b78bd9b5a49a
danny0838 Jul 3, 2025
e926a95
Sync with danny0838/zipremove@86a240bf019fe9212b1e72c963306186163fb8b8
danny0838 Jul 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
  • Loading branch information
danny0838 committed Jun 25, 2025
commit 3a364ce6992501f44f0a098ec3122858db66929d
8 changes: 4 additions & 4 deletions Lib/test/test_zipfile64.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ def _test_strip_removed_large_file_with_dd(self, f):
def test_strip_removed_large_file_with_dd_no_sig(self):
"""Should scan for the data descriptor (without signature) of a removed
large file without causing a memory issue."""
# Reduce data scale for this test, as it's especially slow...
self.datacount = 30*1024**2 // len(self.data)
self.allowed_memory = 200*1024

# Try the temp file. If we do TESTFN2, then it hogs
# gigabytes of disk space for the duration of the test.
with TemporaryFile() as f:
Expand All @@ -210,10 +214,6 @@ def test_strip_removed_large_file_with_dd_no_sig(self):
self.assertLess(peak, self.allowed_memory)

def _test_strip_removed_large_file_with_dd_no_sig(self, f):
# Reduce data scale for this test, as it's especially slow...
self.datacount = 30*1024**2 // len(self.data)
self.allowed_memory = 200*1024

file = 'file.txt'
file1 = 'largefile.txt'
data = b'Sed ut perspiciatis unde omnis iste natus error sit voluptatem'
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy