Skip to content

GH-133136: Revise QSBR to reduce excess memory held #135473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 25, 2025
Merged

GH-133136: Revise QSBR to reduce excess memory held #135473

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7ef2e30
gh-133136: Limit excess memory held by QSBR
colesbury Jun 3, 2025
ce9232b
Fix unused function warning
colesbury Jun 3, 2025
3978e35
Re-work QSBR deferred advance and processing.
nascheme Jun 11, 2025
0b276ab
Update comments.
nascheme Jun 13, 2025
7ea28ff
Revise based on review feedback.
nascheme Jun 16, 2025
d2f5acc
Revert change to _Py_qsbr_advance().
nascheme Jun 17, 2025
ee13392
Call _PyMem_FreeDelayed() from eval breaker.
nascheme Jun 17, 2025
b568dbb
Merge branch 'origin/main' into gh-133136-qsbr-defer-process
nascheme Jun 17, 2025
f5f7a3f
Merge 'origin/main' into gh-133136-qsbr-defer-process
nascheme Jun 25, 2025
03f01b0
Avoid overflow in deferred memory accumulators.
nascheme Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments.
  • Loading branch information
@nascheme
nascheme committed Jun 13, 2025
commit 0b276ab6f77f246b1b75aba4ee28b1b725aeb92c
4 changes: 2 additions & 2 deletions Include/internal/pycore_qsbr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ struct _qsbr_thread_state {
// Thread state (or NULL)
PyThreadState *tstate;

// Number of held items added by this thread since last process
// Number of held items added by this thread since write sequence advance
int deferred_count;

// Estimate for the amount of memory that is held by this thread since
// the last process
// the last write sequence advance
size_t deferred_memory;

// Sequence number at time of last "should process" check.
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy