gh-120713: Make _Py_NORMALIZE_CENTURY private #135933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This'll make it easier to add entries that need longer markup
|
See also other approach in #128444 which allows to get rid of that macro. |
|
Do you intend to backport #128444 to 3.14? |
|
If it is reviewed and accepted. I do not risk to merge it without review. |
|
I'll merge this, and update the other PR(s) to remove the private macro. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 7, 2025
(cherry picked from commit fb170cf) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-136387 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jul 8, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users don't need this macro, and we don't want to document & support it. Right?
(We're not very consistent with configure macros, but we can start making things better with ones added in 3.14.)
datetime.strftime("%Y")is not padding correctly #120713