Skip to content

gh-136229: Remove Platform Emscripten is not supported warning #136230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2025
Merged

gh-136229: Remove Platform Emscripten is not supported warning #136230

merged 2 commits into from
Jul 9, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jul 3, 2025 •
edited by bedevere-app bot
Loading

@hoodmane hoodmane requested a review from freakboy3742 July 3, 2025 08:33
@bedevere-app bedevere-app bot mentioned this pull request Jul 3, 2025
Closed
vstinner
vstinner approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also update https://peps.python.org/pep-0011/#tier-3 ?

@vstinner
Copy link
Member

vstinner commented Jul 3, 2025

By the way, https://peps.python.org/pep-0776/ is still a draft.

blockchainGuru1018
blockchainGuru1018 approved these changes Jul 3, 2025
View reviewed changes
Copy link

@blockchainGuru1018 blockchainGuru1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane approved the pr

emmatyping
emmatyping reviewed Jul 5, 2025
View reviewed changes
configure.ac Outdated
@@ -1226,9 +1226,10 @@ AS_CASE([$host/$ac_cv_cc_name],
[s390x-*-linux-gnu/gcc], [PY_SUPPORT_TIER=3], dnl Linux on 64bit s390x (big endian), glibc, gcc
[x86_64-*-freebsd*/clang], [PY_SUPPORT_TIER=3], dnl FreeBSD on AMD64
[aarch64-apple-ios*-simulator/clang], [PY_SUPPORT_TIER=3], dnl iOS Simulator on arm64
[aarch64-apple-ios*/clang], [PY_SUPPORT_TIER=3], dnl iOS on ARM64
[aarch64-apple-ios*/clang], [PY_SUPPORT_TIER=3], dnl iOS on ARM64
Copy link
Member

@emmatyping emmatyping Jul 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to indent the other entries more to line up with the line containing aarch64-apple-ios*-simulator/clang (so that all the PY_SUPPORT_TIER lines are aligned)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll push a change to that effect.

@freakboy3742
Copy link
Contributor

By the way, https://peps.python.org/pep-0776/ is still a draft.

Noted; however, Emscripten is a bit of a weird case. WASI and Emscripten were both at Tier 3 for Py3.12, without a PEP existing at all; WASI is at Tier 2, and doesn't have a PEP. In addition, the Steering Council has approved restoration to Tier 3 for Emscripten (python/steering-council#256).

I absolutely agree that we should finalize PEP 776; but I don't personally consider it a blocker for this PR.

@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
@freakboy3742 freakboy3742 enabled auto-merge (squash) July 9, 2025 02:20
@freakboy3742 freakboy3742 merged commit 6ea4258 into python:main Jul 9, 2025
37 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@hoodmane @miss-islington
pythongh-136229: Remove Platform Emscripten is not supported warning (p…
5e237c1 
…ythonGH-136230)

Updates configure script to identify Emscripten as Tier 3.
(cherry picked from commit 6ea4258)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136445 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
@freakboy3742 freakboy3742 mentioned this pull request Jul 9, 2025
Merged
freakboy3742 pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @hoodmane
[3.14] gh-136229: Remove Platform Emscripten is not supported warning (…
e0b9f07 
…GH-136230) (#136445)

Updates configure script to identify Emscripten as Tier 3.
(cherry picked from commit 6ea4258)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.14 (tier-2) has failed when building commit e0b9f07.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1710/builds/252) and take a look at the build logs.
  4. Check if the failure is related to this commit (e0b9f07) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1710/builds/252

Failed tests:

  • test_perf_profiler
  • test.test_multiprocessing_spawn.test_threads

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated
  • test_rapid_restart - test.test_multiprocessing_spawn.test_threads.WithThreadsTestManagerRestart.test_rapid_restart

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 373, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 1307 events and lost [35 chars]\n\n' != ''
- Warning:
- Processed 1307 events and lost 5 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/_test_multiprocessing.py", line 3472, in test_rapid_restart
    manager.start()
    ~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/managers.py", line 570, in start
    self._address = reader.recv()
                    ~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/connection.py", line 256, in recv
    buf = self._recv_bytes()
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/connection.py", line 447, in _recv_bytes
    buf = self._recv(4)
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/connection.py", line 416, in _recv
    raise EOFError
EOFError


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/process.py", line 320, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/managers.py", line 595, in _run_server
    server = cls._Server(registry, address, authkey, serializer)
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/managers.py", line 160, in __init__
    self.listener = Listener(address=address, backlog=128)
                    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/connection.py", line 481, in __init__
    self._listener = SocketListener(address, family, backlog)
                     ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/multiprocessing/connection.py", line 625, in __init__
    self._socket.bind(address)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^
OSError: [Errno 98] Address already in use
ERROR
Warning -- Dangling processes: {<SpawnProcess name='QueueManager-12' pid=220210 parent=188549 stopped exitcode=1>}


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 373, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 1469 events and lost [35 chars]\n\n' != ''
- Warning:
- Processed 1469 events and lost 2 chunks!
- 
- Check IO/CPU overload!
-

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@hoodmane @AndPuQing
pythongh-136229: Remove Platform Emscripten is not supported warning (p…
780041b 
…ython#136230)

Updates configure script to identify Emscripten as Tier 3.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hoodmane @Pranjal095
pythongh-136229: Remove Platform Emscripten is not supported warning (p…
d652078 
…ython#136230)

Updates configure script to identify Emscripten as Tier 3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping left review comments

@vstinner vstinner vstinner approved these changes

@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
OS-emscripten skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hoodmane @vstinner @freakboy3742 @bedevere-bot @emmatyping @blockchainGuru1018
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy