Skip to content

gh-136285: Improve pickle protocol testing in test_interpreters #136286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2025
Merged

gh-136285: Improve pickle protocol testing in test_interpreters #136286

merged 4 commits into from
Jul 6, 2025
+28 −30

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 4, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jul 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 4, 2025
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka
Copy link
Member

It looks that there is a bug. So it is better to fix it first and then run tests for all protocols.

@sobolevn sobolevn added the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
@sobolevn sobolevn removed skip news tests Tests in the Lib/test dir labels Jul 5, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

This is the right way that preserves the same semantic as for protocols >= 2.

@sobolevn sobolevn enabled auto-merge (squash) July 6, 2025 07:10
@sobolevn sobolevn merged commit 06e347b into python:main Jul 6, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2025
@sobolevn @miss-islington
pythongh-136285: Improve pickle protocol testing in `test_interpret…
dc51fbc 
…ers` (pythonGH-136286)

(cherry picked from commit 06e347b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jul 6, 2025

GH-136333 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 6, 2025
sobolevn added a commit that referenced this pull request Jul 6, 2025
@miss-islington @sobolevn
[3.14] gh-136285: Improve pickle protocol testing in `test_interpre…
d86ca7b 
…ters` (GH-136286) (#136333)

gh-136285: Improve `pickle` protocol testing in `test_interpreters` (GH-136286)
(cherry picked from commit 06e347b)

Co-authored-by: sobolevn <mail@sobolevn.me>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@sobolevn @AndPuQing
pythongh-136285: Improve pickle protocol testing in `test_interpret…
47ce0d8 
…ers` (python#136286)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-136285: Improve pickle protocol testing in `test_interpret…
3aea58b 
…ers` (python#136286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @serhiy-storchaka
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy