Skip to content

gh-86682: Add versionadded for sys._getframemodulename #136325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

gh-86682: Add versionadded for sys._getframemodulename #136325

merged 1 commit into from
Jul 7, 2025

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jul 5, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 5, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jul 5, 2025
@emmatyping emmatyping changed the title add versionadded for sys._getframemodulename Add versionadded for sys._getframemodulename Jul 5, 2025
@emmatyping
Copy link
Member

emmatyping commented Jul 5, 2025 •
edited
Loading

Ah, I wonder if this wasn't added originally because the function is private looks like there are other examples of private functions with version added directives

@StanFromIreland StanFromIreland changed the title Add versionadded for sys._getframemodulename gh-86682: Add versionadded for sys._getframemodulename Jul 5, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 5, 2025
Closed
StanFromIreland
StanFromIreland approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS. @emmatyping you can attach previous issues to PRs rather than skip.

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 5, 2025
@kumaraditya303 kumaraditya303 merged commit 11f074b into python:main Jul 7, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 7, 2025
@miss-islington-app
Copy link

Thanks @asottile for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@asottile @miss-islington
pythongh-86682: Add versionadded for sys._getframemodulename (pythonG…
035c74c 
…H-136325)

add versionadded for sys._getframemodulename
(cherry picked from commit 11f074b)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@asottile @miss-islington
pythongh-86682: Add versionadded for sys._getframemodulename (pythonG…
a5f4537 
…H-136325)

add versionadded for sys._getframemodulename
(cherry picked from commit 11f074b)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136375 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136376 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 7, 2025
kumaraditya303 pushed a commit that referenced this pull request Jul 7, 2025
@miss-islington @asottile
[3.14] gh-86682: Add versionadded for sys._getframemodulename (GH-136325
a7dd48a 
) (#136375)

gh-86682: Add versionadded for sys._getframemodulename (GH-136325)

add versionadded for sys._getframemodulename
(cherry picked from commit 11f074b)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
kumaraditya303 pushed a commit that referenced this pull request Jul 7, 2025
@miss-islington @asottile
[3.13] gh-86682: Add versionadded for sys._getframemodulename (GH-136325
843e805 
) (#136376)

gh-86682: Add versionadded for sys._getframemodulename (GH-136325)

add versionadded for sys._getframemodulename
(cherry picked from commit 11f074b)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@asottile @AndPuQing
pythongh-86682: Add versionadded for sys._getframemodulename (python#…
4905390 
…136325)

add versionadded for sys._getframemodulename
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@asottile @Pranjal095
pythongh-86682: Add versionadded for sys._getframemodulename (python#…
b086b44 
…136325)

add versionadded for sys._getframemodulename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asottile @emmatyping @ZeroIntensity @StanFromIreland @kumaraditya303
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy