gh-136355: Deprecate -b and -bb CLI flags in 3.15
#136363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jul 7, 2025
| @@ -254,6 +254,16 @@ Miscellaneous options | |||
| .. versionchanged:: 3.5 | |||
| Affects also comparisons of :class:`bytes` with :class:`int`. | |||
|
|
|||
| .. deprecated-removed:: 3.15 3.17 | |||
|
|
|||
| Deprecate :option:`-b` and :option:`-bb` | |||
There was a problem hiding this comment.
Suggested change
| Deprecate :option:`-b` and :option:`-bb` | |
| Deprecate :option:`-b` and :option:`!-bb` |
| @@ -256,6 +256,7 @@ static const char usage_help[] = "\ | |||
| Options (and corresponding environment variables):\n\ | |||
| -b : issue warnings about converting bytes/bytearray to str and comparing\n\ | |||
| bytes/bytearray with str or bytes with int. (-bb: issue errors)\n\ | |||
| deprecated since 3.15 and will be removed in 3.17\n\ | |||
There was a problem hiding this comment.
Suggested change
| deprecated since 3.15 and will be removed in 3.17\n\ | |
| deprecated since 3.15 and will be removed in 3.17.\n\ |
| if (!config->bytes_warning) { | ||
| fprintf(stderr, | ||
| "-b option is deprecated since Python 3.15 " | ||
| "and will be removed in Python 3.17\n"); |
There was a problem hiding this comment.
I would prefer to move this code at the end of pyinit_core() (before done: label). Example:
if (_Py_GetConfig()->bytes_warning) {
fprintf(stderr,
"-b option is deprecated since Python 3.15 "
"and will be removed in Python 3.17\n");
}So it deprecates indirectly the PyConfig.bytes_warning member.
malemburg
requested changes
Jul 7, 2025
| In 3.17 no :exc:`BytesWarning` won't be raised for these cases. | ||
| If you want to check for the same things in the future, | ||
| use any type-checker of your choice. | ||
|
|
There was a problem hiding this comment.
You must have forgotten to add the other suggestion, only one (this) appears for me.
There was a problem hiding this comment.
Hmm, Github's UI is a nightmare. Added it again.
|
When you're done making the requested changes, leave the comment: |
malemburg
reviewed
Jul 7, 2025
| In 3.17 no :exc:`BytesWarning` won't be raised for these cases. | ||
| If you want to check for the same things in the future, | ||
| use any type-checker of your choice. | ||
|
|
There was a problem hiding this comment.
Suggested improved wording:
and schedule them for removal in Python 3.17.
They were mainly meant as transition helpers for Python2 -> Python3 era.
Starting with 3.17, the :exc:`BytesWarning` will be dropped for these cases.
If you want to check for the same things in the future,
please use a type-checker of your choice.
There was a problem hiding this comment.
I suggest slightly simpler;
and schedule them for removal in Python 3.17.
These were primarily helpers for the Python2 -> Python3 transition.
Starting with 3.17, no :exc:`BytesWarning` will be raised for these cases.
If you want to check for the same things in the future, use a type-checker.
hugovk
reviewed
Jul 7, 2025
Comment on lines
+261
to
+264
| They were mainly a transition helpers for Python2 -> Python3 era. | ||
| In 3.17 no :exc:`BytesWarning` won't be raised for these cases. | ||
| If you want to check for the same things in the future, | ||
| use any type-checker of your choice. |
There was a problem hiding this comment.
Based on MAL and Stan's good suggestions:
Suggested change
| They were mainly a transition helpers for Python2 -> Python3 era. | |
| In 3.17 no :exc:`BytesWarning` won't be raised for these cases. | |
| If you want to check for the same things in the future, | |
| use any type-checker of your choice. | |
| These were primarily helpers for the Python 2 -> 3 transition. | |
| Starting with Python 3.17, no :exc:`BytesWarning` will be raised | |
| for these cases; use a type checker instead. |
Comment on lines
+214
to
+217
| They were mainly a transition helpers for Python2 -> Python3 era. | ||
| In 3.17 no :exc:`BytesWarning` won't be raised for these cases. | ||
| If you want to check for the same things in the future, | ||
| use any type-checker of your choice. |
There was a problem hiding this comment.
Suggested change
| They were mainly a transition helpers for Python2 -> Python3 era. | |
| In 3.17 no :exc:`BytesWarning` won't be raised for these cases. | |
| If you want to check for the same things in the future, | |
| use any type-checker of your choice. | |
| These were primarily helpers for the Python 2 -> 3 transition. | |
| Starting with Python 3.17, no :exc:`BytesWarning` will be raised | |
| for these cases; use a type checker instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-band-bbCLI flags #136355📚 Documentation preview 📚: https://cpython-previews--136363.org.readthedocs.build/