GH-91636: Clear weakrefs created by finalizers. #136401
Merged
+54
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have `tp_clear` called on them to Python-level code.
|
@colesbury In case you want to look at the free_threading_gc changes. |
|
Looks good to me. |
colesbury
reviewed
Jul 8, 2025
Add a boolean flag to indicate that callbacks should be enabled. This allows the same function to be used before and after finalizer execution.
| if (!allow_callbacks) { | ||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe it is worth to add an assert here for old != NULL?
There was a problem hiding this comment.
Similar question: The old and allow_callbacks arguments are orthogonal even in older versions?
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have `tp_clear` called on them to Python-level code.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have `tp_clear` called on them to Python-level code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have
tp_clearcalled on them to Python-level code.Note that this is part of the GH-136189 change, split out to make it easier for back-porting. This change is conceptually quite simple and is a candidate to backport to all older Python versions (this bug existed for a long time, perhaps in version 2.3). There is some duplicated code between
handle_finalizersandclear_finalizersbut I think it's simpler just to leave that duplication. In the "main" branch I'll clean that up.