gh-134043: use _Py_dict_lookup_threadsafe_stackref for dict lookup in _PyObject_GetMethodStackRef
#136412
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Jul 8, 2025
There was a problem hiding this comment.
- We should add a scaling benchmark to
ftscalingbench.pyfor the relevant access pattern - We probably need to avoid
Py_INCREF(dict)and that's going to require refactoring. You can safely avoidPy_INCREF(dict)in the same cases where_Py_dict_lookup_threadsafe_stackrefis relevant: when the dictionary keys areDICT_KEYS_UNICODE.
|
This needs more refactoring - we can't load the keys twice like this because the condition might not hold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_PyObject_GetMethodand calling APIs #134043Changes
_PyObject_GetMethodStackRefto use_Py_dict_lookup_threadsafe_stackrefto avoid reference counting on deferred objects.