Skip to content

Update bytecode magic number in tests for the 3.14 release candidate #136427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Update bytecode magic number in tests for the 3.14 release candidate #136427

merged 1 commit into from
Jul 8, 2025
+1 −1

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 8, 2025

The release script reminds:

warning: Magic numbers in ../cpython/Include/internal/pycore_magic_number.h (3625) and ../cpython/Lib/test/test_importlib/test_util.py (3495) don't match.
Do you want to continue? This will fail tests in RC stage.

@hugovk hugovk added the needs backport to 3.14 bugs and security fixes label Jul 8, 2025
@hugovk hugovk requested a review from warsaw as a code owner July 8, 2025 16:18
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jul 8, 2025
@hugovk hugovk added skip issue skip news and removed tests Tests in the Lib/test dir awaiting core review labels Jul 8, 2025
@StanFromIreland StanFromIreland added tests Tests in the Lib/test dir awaiting core review labels Jul 8, 2025
@StanFromIreland

This comment was marked as resolved.

Sign in to view
@hugovk hugovk merged commit bc9bc07 into python:main Jul 8, 2025
57 checks passed
@hugovk hugovk deleted the 3.14-magic-number branch July 8, 2025 17:11
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 8, 2025
@hugovk @miss-islington
Update bytecode magic number in tests for the 3.14 release candidate (p…
a099f16 
…ythonGH-136427)

(cherry picked from commit bc9bc07)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 8, 2025

GH-136429 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 8, 2025
hugovk added a commit that referenced this pull request Jul 8, 2025
@miss-islington @hugovk
[3.14] Update bytecode magic number in tests for the 3.14 release can…
66f85f4 
…didate (GH-136427) (#136429)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@hugovk @AndPuQing
Update bytecode magic number in tests for the 3.14 release candidate (p…
e29e7c7 
…ython#136427)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hugovk @Pranjal095
Update bytecode magic number in tests for the 3.14 release candidate (p…
f93708e 
…ython#136427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @StanFromIreland
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy