Skip to content

gh-91048: Revert the memory cache removal for remote debugging #136440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 8, 2025

Some users have complained that removing the cache makes async introspection slower

@pablogsal
Copy link
Member Author

Note: this partially reverts the cache removal of #136005 so this code was in previous betas, just reverting back to it.

@pablogsal pablogsal changed the title gh-91048: Reintroduce the memory cache for remote debugging gh-91048: Revert the memory cache removal for remote debugging Jul 8, 2025
@pablogsal
Copy link
Member Author

Confirmed the regression:

Current:

Real-time sampling stats: Mean: 4498.8Hz (222.28µs) Min: 83.1Hz (12029.75µs) Max: 5065.9Hz (197.40µs) Samples: 7503^CTraceback (most recent call last):

Before the cache removal:

Real-time sampling stats: Mean: 10835.8Hz (92.29µs) Min: 81.9Hz (12207.85µs) Max: 11610.2Hz (86.13µs) Samples: 7413

@pablogsal pablogsal enabled auto-merge (squash) July 8, 2025 23:55
@pablogsal pablogsal merged commit 77d25e5 into python:main Jul 9, 2025
39 checks passed
@pablogsal pablogsal deleted the cache branch July 9, 2025 00:31
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
…ythonGH-136440)

(cherry picked from commit 77d25e5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pythongh-91048: Reintroduce the memory cache for remote debugging
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136443 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
pablogsal added a commit that referenced this pull request Jul 9, 2025
…GH-136440) (#136443)

gh-91048: Revert the memory cache removal for remote debugging (GH-136440)
(cherry picked from commit 77d25e5)


gh-91048: Reintroduce the memory cache for remote debugging

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot

This comment has been minimized.

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy