Skip to content

gh-136447: Use self.loop instead of global loop variable in asyncio REPL #136448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

gh-136447: Use self.loop instead of global loop variable in asyncio REPL #136448

merged 1 commit into from
Jul 9, 2025

Conversation

injust
Copy link
Contributor

@injust injust commented Jul 9, 2025 •
edited
Loading

loop is passed to AsyncIOInteractiveConsole and assigned to the instance attribute self.loop.

This PR fixes the one place where AsyncIOInteractiveConsole uses the global loop variable instead of self.loop.

@python-cla-bot
Copy link

python-cla-bot bot commented Jul 9, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jul 9, 2025
Closed
@kumaraditya303 kumaraditya303 merged commit 77fa7a4 into python:main Jul 9, 2025
49 checks passed
@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 9, 2025
@miss-islington-app
Copy link

Thanks @injust for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @injust for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@injust @miss-islington
pythongh-136447: Use self.loop instead of global loop variable in…
7fcbe06 
… asyncio REPL (pythonGH-136448)

(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136457 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@injust @miss-islington
pythongh-136447: Use self.loop instead of global loop variable in…
441b440 
… asyncio REPL (pythonGH-136448)

(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 9, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136458 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
kumaraditya303 pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @injust
[3.13] gh-136447: Use self.loop instead of global loop variable i…
532ecac 
…n asyncio REPL (GH-136448) (#136457)

gh-136447: Use `self.loop` instead of global `loop` variable in asyncio REPL (GH-136448)
(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
kumaraditya303 pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @injust
[3.14] gh-136447: Use self.loop instead of global loop variable i…
19518a4 
…n asyncio REPL (GH-136448) (#136458)

gh-136447: Use `self.loop` instead of global `loop` variable in asyncio REPL (GH-136448)
(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@injust @AndPuQing
pythongh-136447: Use self.loop instead of global loop variable in…
795dd84 
… asyncio REPL (python#136448)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@injust @Pranjal095
pythongh-136447: Use self.loop instead of global loop variable in…
f1b1766 
… asyncio REPL (python#136448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injust @kumaraditya303
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy