Skip to content

gh-52876: Implement missing parameter in codecs.StreamReaderWriter functions #136498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

gh-52876: Implement missing parameter in codecs.StreamReaderWriter functions #136498

merged 3 commits into from
Jul 10, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jul 10, 2025 •
edited by bedevere-app bot
Loading

This is a bug since, per docs:

StreamReaderWriter instances define the combined interfaces of StreamReader and StreamWriter classes. They inherit all other methods and attributes from the underlying stream.

@bedevere-app bedevere-app bot mentioned this pull request Jul 10, 2025
Closed
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 10, 2025
malemburg
malemburg approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malemburg
Copy link
Member

I'm not sure about the backports, though. This could be seen as a new feature.

@malemburg malemburg merged commit 35e2c35 into python:main Jul 10, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @malemburg for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2025
@StanFromIreland @miss-islington
pythongh-52876: Implement missing parameter in `codecs.StreamReaderWr…
9e7cf20 
…iter` functions (pythonGH-136498)

Closes pythonGH-52876
(cherry picked from commit 35e2c35)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Jul 10, 2025 •
edited
Loading

It currently contradicts the docs, and this would bring it to the expected behaviour. There was a similar consensus on the issue.

@bedevere-app
Copy link

bedevere-app bot commented Jul 10, 2025

GH-136514 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2025
@StanFromIreland @miss-islington
pythongh-52876: Implement missing parameter in `codecs.StreamReaderWr…
2fd47c1 
…iter` functions (pythonGH-136498)

Closes pythonGH-52876
(cherry picked from commit 35e2c35)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 10, 2025

GH-136515 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 10, 2025
@malemburg
Copy link
Member

It currently contradicts the docs, and this would bring it to the expected behaviour. There was a similar consensus on the issue.

Fair enough.

malemburg pushed a commit that referenced this pull request Jul 10, 2025
@miss-islington @StanFromIreland
[3.13] gh-52876: Implement missing parameter in `codecs.StreamReaderW…
aa3c642 
…riter` functions (GH-136498) (#136515)

gh-52876: Implement missing parameter in `codecs.StreamReaderWriter` functions (GH-136498)

Closes GH-52876
(cherry picked from commit 35e2c35)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
malemburg pushed a commit that referenced this pull request Jul 10, 2025
@miss-islington @StanFromIreland
[3.14] gh-52876: Implement missing parameter in `codecs.StreamReaderW…
183b020 
…riter` functions (GH-136498) (#136514)

gh-52876: Implement missing parameter in `codecs.StreamReaderWriter` functions (GH-136498)

Closes GH-52876
(cherry picked from commit 35e2c35)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@StanFromIreland @AndPuQing
pythongh-52876: Implement missing parameter in `codecs.StreamReaderWr…
27b12f0 
…iter` functions (python#136498)

Closes python#52876
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-52876: Implement missing parameter in `codecs.StreamReaderWr…
a882a3f 
…iter` functions (python#136498)

Closes python#52876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malemburg malemburg malemburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @malemburg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy