gh-136507: Fix mimetypes CLI cannot handle multiple file parameters #136508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Jul 10, 2025
Lib/mimetypes.py
Outdated
Comment on lines
725
to
726
| print(help_text) | ||
| return |
There was a problem hiding this comment.
This is an error; could you print to stderr and exit wit an error code?
There was a problem hiding this comment.
No problem. I'll solve it tomorrow :)
There was a problem hiding this comment.
If this is validating for a non-empty string(?), then perhaps a specific error should be communicated.
There was a problem hiding this comment.
This is an error; could you print to stderr and
exitwit an error code?
I switched to a different fix implementation and now use list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.