Skip to content

gh-136523: fix wave.Wave_write emitting an unraisable when open raises #136529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 13, 2025
Merged

gh-136523: fix wave.Wave_write emitting an unraisable when open raises #136529

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4f3f19
gh-136523: fix Wave_write.__del__ raise after wb open
inventshah Jul 11, 2025
d4a5986
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 11, 2025
66e64b6
skip test when no chmod (wasi), fix doc lint
inventshah Jul 11, 2025
288f527
simplify patch, fix test robustness to running env
inventshah Jul 12, 2025
c33b908
fix test on Windows by catching OSError
inventshah Jul 12, 2025
78ac6b2
test updates: assert open raises, use curdir, rename
inventshah Jul 12, 2025
9c10b37
update NEWS
inventshah Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update NEWS
  • Loading branch information
@inventshah
inventshah committed Jul 12, 2025
commit 9c10b37090967be084250d05a4cb269cc8529e41
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2025-07-11-03-39-15.gh-issue-136523.s7caKL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fix :class:`wave.Wave_write` emitting an unraisable :exc:`AttributeError` when attempting to open an unwritable file.
Fix :class:`wave.Wave_write` emitting an unraisable when open raises.
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy