Skip to content

[3.13] gh-136541: Fix several problems of perf trampolines in x86_64 and aarch64 (GH-136500) #136545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 11, 2025

This commit fixes the following problems:

  • The x86_64 trampolines are not preserving frame pointers
  • The hardcoded offsets to the code segment from the FDE only worked properly for x64_64
  • The CIE data was not following conventions of aarch64
  • The eh_frame for aarch64 was not fully correct (cherry picked from commit 236f733)

…86_64 and aarch64 (pythonGH-136500)

This commit fixes the following problems:

* The x86_64 trampolines are not preserving frame pointers
* The hardcoded offsets to the code segment from the FDE only worked properly for x64_64
* The CIE data was not following conventions of aarch64
* The eh_frame for aarch64 was not fully correct
(cherry picked from commit 236f733)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal pablogsal requested a review from brandtbucher as a code owner July 11, 2025 13:40
@pablogsal pablogsal enabled auto-merge (squash) July 11, 2025 13:57
@pablogsal pablogsal merged commit cba2974 into python:3.13 Jul 11, 2025
38 checks passed
@pablogsal pablogsal deleted the backport-236f733-3.13 branch July 11, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy