Skip to content

gh-136549: Fix signature of threading.excepthook() #136559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2025
Merged

gh-136549: Fix signature of threading.excepthook() #136559

merged 2 commits into from
Jul 12, 2025
+3 −1

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 11, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 11, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 11, 2025
Closed
@ZeroIntensity
Copy link
Member

Is there any reason this wasn't caught by regrtest?

@serhiy-storchaka
Copy link
Member Author

Regrtest sets different threading.excepthook.

ZeroIntensity
ZeroIntensity reviewed Jul 12, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. The core change looks good to me. Could we add a simple test for this? Something like inspect.signature(threading.__excepthook__) should work.

ZeroIntensity
ZeroIntensity approved these changes Jul 12, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit be2c3d2 into python:main Jul 12, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2025
@serhiy-storchaka @miss-islington
pythongh-136549: Fix signature of threading.excepthook() (pythonGH-13…
f46ed2a 
…6559)

(cherry picked from commit be2c3d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 12, 2025

GH-136589 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2025
@serhiy-storchaka @miss-islington
pythongh-136549: Fix signature of threading.excepthook() (pythonGH-13…
3bfa503 
…6559)

(cherry picked from commit be2c3d284ecce67474a260b8c37e2f1e0628a9cf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 12, 2025

GH-136590 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 12, 2025
@serhiy-storchaka serhiy-storchaka deleted the threading-excepthook-signature branch July 12, 2025 15:54
serhiy-storchaka added a commit that referenced this pull request Jul 12, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-136549: Fix signature of threading.excepthook() (GH-136559) (…
d733a1e 
…GH-136590)

(cherry picked from commit be2c3d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jul 12, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-136549: Fix signature of threading.excepthook() (GH-136559) (…
64df22c 
…GH-136589)

(cherry picked from commit be2c3d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @ZeroIntensity
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy