Skip to content

gh-136572: fix IndexError in pydoc.replace #136574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/pydoc.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,11 @@ def isdata(object):

def replace(text, *pairs):
"""Do a series of global replacements on a string."""
while pairs:
text = pairs[1].join(text.split(pairs[0]))
pairs = pairs[2:]
if len(pairs) % 2:
# len(pairs) must be even, so len(pairs) + 1 must be odd
raise TypeError("an odd number of arguments must be given")
for ind in range(0, len(pairs), 2):
text = pairs[ind + 1].join(text.split(pairs[ind]))
return text

def cram(text, maxlen):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:func:`!pydoc.replace` now raises a :exc:`TypeError` instead of an
:exc:`IndexError` when the number of variadic arguments is odd (or
equivalently, if the total number of arguments is even).
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy