DOC: Clarify version number in logging.rst #136585
Conversation
Fix typo: "due to retain" → "in order to retain" "in order" is grammatically redundant, but it's to avoid having homophones "2" and "to" right next to each other.
3.4 technically includes 3.4.2, so put 3.4.0 to clarify.
|
All commit authors signed the Contributor License Agreement. |
|
I don't think 2 PRs are nesecarry for such a small section. Ps. You need to sign the CLA |
| text level, and would return the corresponding numeric value of the level. | ||
| This undocumented behaviour was considered a mistake, and was removed in | ||
| Python 3.4, but reinstated in 3.4.2 due to retain backward compatibility. | ||
| Python 3.4.0, but reinstated in 3.4.2 in order to retain backward compatibility. |
There was a problem hiding this comment.
Is this duplicate to #136584 ? We actually treat them separately.
| Python 3.4.0, but reinstated in 3.4.2 in order to retain backward compatibility. | |
| Python 3.4.0, but reinstated in 3.4.2 due to retain backward compatibility. |
There was a problem hiding this comment.
Sorry, what do you mean by "separately"?
I have signed the agreement, years ago, just not under this GitHub email address. |
|
Then you must also add your gh address. |
|
I don't think it's necessary. Python 3.4 is really EOL and IMO it's sufficiently clear considering the rest of the paragraph. We also don't have a policy of mentioning the minor version in such notes (I think we should even remove the mention to 3.4.2 now because it's really something that is not useful to the user reading the online notes). I'm going to reject this one. |
3.4 technically includes 3.4.2, so put 3.4.0 to clarify.
Doc/library/logging.rst#136584📚 Documentation preview 📚: https://cpython-previews--136585.org.readthedocs.build/